Cairo: Add ERC1155 #351
Cairo: Add ERC1155 #351
Conversation
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
|
@SocketSecurity ignore npm/svelte-preprocess@5.1.3 |
andrew-fleming
left a comment
andrew-fleming
left a comment
There was a problem hiding this comment.
Changes look good! One small thing: I know it's by design to import the components first, but it appears a little unorganized when, for instance, selecting Roles and Upgradeable. Here's the ouput:
use openzeppelin::token::erc1155::ERC1155Component;
use openzeppelin::introspection::src5::SRC5Component
use openzeppelin::access::accesscontrol::AccessControlComponent
use openzeppelin::upgrades::UpgradeableComponent
use openzeppelin::access::accesscontrol::DEFAULT_ADMIN_ROLE
use openzeppelin::upgrades::interface::IUpgradeable;
The cairo formatter alphabetizes the imports on our end. IMO it'd make sense to follow the formatter. It should also help simplify getCategorizedImports in the wizard 🤞 what do you think?
|
@andrew-fleming Thanks for the suggestion! Updated to sort the imports alphabetically. |
| assert(self.erc1155.is_approved_for_all(account, caller), ERC1155Component::Errors::UNAUTHORIZED);␊ | ||
| if account != caller {␊ | ||
| assert(self.erc1155.is_approved_for_all(account, caller), ERC1155Component::Errors::UNAUTHORIZED);␊ | ||
| }␊ |
3 participants
Uh oh!
There was an error while loading. Please reload this page.